Fix duplicate menu entries in Available Functions for URI-based sources#765
Open
sperrault wants to merge 1 commit intomcneel:8.xfrom
Open
Fix duplicate menu entries in Available Functions for URI-based sources#765sperrault wants to merge 1 commit intomcneel:8.xfrom
sperrault wants to merge 1 commit intomcneel:8.xfrom
Conversation
When multiple components share a common URI path prefix (e.g., /seaborn/relplot, /seaborn/catplot, /seaborn/boxplot), each component would create a separate parent menu entry instead of grouping them under a single parent. This fix checks if a parent path already exists in the Paths collection before creating a new one, ensuring components with shared prefixes are properly grouped under a single submenu. Fixes mcneel#363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple components share a common URI path prefix (e.g., /prefix/component_1, /prefix/component_2, /prefix/component_3), each component would create a separate parent menu entry instead of grouping them under a single parent.
This fix checks if a parent path already exists in the Paths collection before creating a new one, ensuring components with shared prefixes are properly grouped under a single submenu.
Fixes #363
Related discussion: https://discourse.mcneel.com/t/grouping-hops-components-in-available-functions/195331